Discussion:
[zathura] [PATCH] Initialize bisect state
Abdó Roig-Maranges
2013-07-07 15:27:25 UTC
Permalink
A small fix for the bisect thing. When opening a new document at page 1, the
bisect algorithm does not understand that it must begin a new bisect, and does
not move from page 0 (the bisect struct is all initialized to 0's).

The attached patch initializes the bisect range to 0, numpages-1, so that the
first bisect always has range the entire document.

Also I attach a small patch regarding empty jumplists. sc_jumplist detects such
case with an assertion. I think it is better to use regular flow control, and
leave assertions for exceptional things that should never happen, like a NULL
zathura pointer.

Abd?.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: zathura-bisect-init.patch
Type: text/x-diff
Size: 1061 bytes
Desc: initialize bisect state
URL: <http://lists.pwmt.org/archive/zathura/attachments/20130707/0067a7e3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jumplist-assertion.patch
Type: text/x-diff
Size: 1155 bytes
Desc: fix empty jumplist assertion
URL: <http://lists.pwmt.org/archive/zathura/attachments/20130707/0067a7e3/attachment-0001.patch>
Loading...