Discussion:
[zathura] [Zathura PATCH] Minor cleanup
Marwan Tanager
2013-10-26 01:00:32 UTC
Permalink
Since we 'continue' the loop if num_search_results is 0, there is no need for
the second check.

---
shortcuts.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/shortcuts.c b/shortcuts.c
index bf43446..435d089 100644
--- a/shortcuts.c
+++ b/shortcuts.c
@@ -965,13 +965,12 @@ sc_search(girara_session_t* session, girara_argument_t* argument,
GtkWidget* page_widget = zathura_page_get_widget(zathura, page);

int num_search_results = 0, current = -1;
- g_object_get(page_widget, "search-current", &current,
- "search-length", &num_search_results, NULL);
+ g_object_get(page_widget, "search-current", &current, "search-length", &num_search_results, NULL);
if (num_search_results == 0 || current == -1) {
continue;
}

- if ((first_time_after_abort == true && num_search_results > 0) || ((tmp + num_pages) % num_pages != cur_page)) {
+ if (first_time_after_abort == true || (tmp + num_pages) % num_pages != cur_page) {
target_page = page;
target_idx = diff == 1 ? 0 : num_search_results - 1;
break;
--
1.7.10.4
Loading...