[zathura] jumplist-size option generates critical warning

Discussion:

Αριστοτέλης Πανάρας

2014-04-23 17:08:39 UTC

Hello. I am new here, so forgive me for asking things that might have
already been discussed.

1. On develop branch, and more specifically commit 3285d61, setting
jumplist-size option in zathurarc seems to generate a critical warning.

Reproducible by creating a zathurarc with the following line:

set jumplist-size 2000

, the output is as follows:

debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/djvu.so
debug: (zathura_plugin_manager_load:207) plugin '/usr/lib/zathura/djvu.so':
version 0.2.3
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/pdf.so
debug: (zathura_plugin_manager_load:207) plugin '/usr/lib/zathura/pdf.so':
version 0.2.6
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/ps.so
debug: (zathura_plugin_manager_load:207) plugin '/usr/lib/zathura/ps.so':
version 0.2.2
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/cb.so
debug: (zathura_plugin_manager_load:207) plugin '/usr/lib/zathura/cb.so':
version 0.1.2

** (zathura:12942): CRITICAL **: zathura_jumplist_trim: assertion 'zathura
!= NULL && zathura->jumplist.list != NULL && zathura->jumplist.size != 0'
failed
debug: (zathura_init:202) Using plain database backend.
debug: (bus_acquired:88) Bus acquired at 'org.pwmt.zathura.PID-12942'.
debug: (name_acquired:111) Acquired 'org.pwmt.zathura.PID-12942' on session
bus.
debug: (guess_type_magic:57) magic detected filetype: application/pdf
debug: (zathura_jumplist_load:1364) Loaded the jumplist from the database
debug: (page_cache_is_cached:820) Page 1 is a cache miss
debug: (zathura_renderer_page_cache_add:920) Page 1 is cached at cache
index 0
debug: (render_job:749) Rendering page 1 ...
debug: (emit_completed_signal:505) Emitting signal for page 1

.
It would seem that it is due to the zathura_jumplist_trim() call generated
by setting the jumplist-size in the rc file. More specifically, the
cb_jumplist_change() callback seems to call zathura_jumplist_trim() before
the document jumplist is loaded in document_open_idle().

2. Since I changed to the develop branch (zathura-git in Arch AUR), the
index mode seems to have changed a bit.
The default colors seem to have changed (white foreground in black
background) and the currently selected object is not visible anymore as it
was before (where is was grey on white background). That seems to not be
configurable at the moment.
3. Also, I might be mistaken, but was the scrollbar always present in index
mode when guioptions did not contain v?

Thank you and sorry for taking up your time.

Aristoteles Panaras
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pwmt.org/archive/zathura/attachments/20140423/f4c8e127/attachment.html>

Sebastian Ramacher

2014-04-23 17:26:51 UTC

Permalink

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
Hello. I am new here, so forgive me for asking things that might have
already been discussed.
1. On develop branch, and more specifically commit 3285d61, setting
jumplist-size option in zathurarc seems to generate a critical warning.
set jumplist-size 2000
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/djvu.so
version 0.2.3
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/pdf.so
version 0.2.6
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/ps.so
version 0.2.2
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/cb.so
version 0.1.2
** (zathura:12942): CRITICAL **: zathura_jumplist_trim: assertion 'zathura
!= NULL && zathura->jumplist.list != NULL && zathura->jumplist.size != 0'
failed
debug: (zathura_init:202) Using plain database backend.
debug: (bus_acquired:88) Bus acquired at 'org.pwmt.zathura.PID-12942'.
debug: (name_acquired:111) Acquired 'org.pwmt.zathura.PID-12942' on session
bus.
debug: (guess_type_magic:57) magic detected filetype: application/pdf
debug: (zathura_jumplist_load:1364) Loaded the jumplist from the database
debug: (page_cache_is_cached:820) Page 1 is a cache miss
debug: (zathura_renderer_page_cache_add:920) Page 1 is cached at cache
index 0
debug: (render_job:749) Rendering page 1 ...
debug: (emit_completed_signal:505) Emitting signal for page 1
.
It would seem that it is due to the zathura_jumplist_trim() call generated
by setting the jumplist-size in the rc file. More specifically, the
cb_jumplist_change() callback seems to call zathura_jumplist_trim() before
the document jumplist is loaded in document_open_idle().

I'll look at that.

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
2. Since I changed to the develop branch (zathura-git in Arch AUR), the
index mode seems to have changed a bit.
The default colors seem to have changed (white foreground in black
background) and the currently selected object is not visible anymore as it
was before (where is was grey on white background). That seems to not be
configurable at the moment.
3. Also, I might be mistaken, but was the scrollbar always present in index
mode when guioptions did not contain v?

If I remember correctly (and please correct me if I am wrong, I'm not an Arch
user), zathura-git pulls girara-git so you get all the new theming code from
girara. We are currently changing the way we theme girara from gtk_widget_*
calls to CSS. So if anything is broken theming wise, this might just be a
consequence of that. Please let us know of any such unexpected difference so we
can fix them before releasing the next version of girara.

Cheers

--
Sebastian Ramacher

Αριστοτέλης Πανάρας

2014-04-23 20:25:39 UTC

Permalink

1. Thanks.
2,3. That is correct, zathura-git pulls girara.git's develop branch and
links it with gtk3 (package girara-gtk3-git).
In that case, the index colors mode could well be due to an issue with
girara.
Should I file a bug report or is this mail sufficient?
4. Since you mentioned a restructuring in girara's theming, there is one
more thing.
There is a separator that appears in 2 places: around the input buffer in
the statusbar, and between commands and descriptions in the completion menu.
I am not sure anymore, as I am becoming more accustomed to the new look,
but I think that previously it was not visible (it had the same color with
its surroundings), but after the change to develop branch it became visible
as it is currently black.
It can be witnessed with the following rc:

set completion-bg "#232323"
set completion-fg "#707070"
set completion-group-bg "#C0C0C0"
set completion-group-fg "#DEDEDE"
set completion-highlight-bg "#336600"
set completion-highlight-fg "#232323"
set inputbar-bg "#131313"
set inputbar-fg "#9FBC00"
set statusbar-bg "#200000"
set statusbar-fg "#FFFFFF"
set statusbar-h-padding 2
set statusbar-v-padding 0

Thank you for responding.

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï

'zathura

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
!= NULL && zathura->jumplist.list != NULL && zathura->jumplist.size != 0'
failed
debug: (zathura_init:202) Using plain database backend.
debug: (bus_acquired:88) Bus acquired at 'org.pwmt.zathura.PID-12942'.
debug: (name_acquired:111) Acquired 'org.pwmt.zathura.PID-12942' on

session

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
bus.
debug: (guess_type_magic:57) magic detected filetype: application/pdf
debug: (zathura_jumplist_load:1364) Loaded the jumplist from the database
debug: (page_cache_is_cached:820) Page 1 is a cache miss
debug: (zathura_renderer_page_cache_add:920) Page 1 is cached at cache
index 0
debug: (render_job:749) Rendering page 1 ...
debug: (emit_completed_signal:505) Emitting signal for page 1
.
It would seem that it is due to the zathura_jumplist_trim() call

generated

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
by setting the jumplist-size in the rc file. More specifically, the
cb_jumplist_change() callback seems to call zathura_jumplist_trim()

before

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
the document jumplist is loaded in document_open_idle().

I'll look at that.

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
was before (where is was grey on white background). That seems to not be
configurable at the moment.
3. Also, I might be mistaken, but was the scrollbar always present in

index

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
mode when guioptions did not contain v?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pwmt.org/archive/zathura/attachments/20140423/31bf003c/attachment-0001.html>

Sebastian Ramacher

2014-04-23 23:31:59 UTC

Permalink

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
1. Thanks.
2,3. That is correct, zathura-git pulls girara.git's develop branch and
links it with gtk3 (package girara-gtk3-git).
In that case, the index colors mode could well be due to an issue with
girara.
Should I file a bug report or is this mail sufficient?

The mail is sufficient. If you find anything else, please let us know.

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
4. Since you mentioned a restructuring in girara's theming, there is one
more thing.
There is a separator that appears in 2 places: around the input buffer in
the statusbar, and between commands and descriptions in the completion menu.
I am not sure anymore, as I am becoming more accustomed to the new look,
but I think that previously it was not visible (it had the same color with
its surroundings), but after the change to develop branch it became visible
as it is currently black.

Yes, I saw that too. Just haven't found a way to give them the correct
background color. In other words: I do not know which widget has the wrong
background color.

(I think this issue exists since the GTK+ 3 switch, but I'm not sure.)

Cheers

--
Sebastian Ramacher

Sebastian Ramacher

2014-04-26 20:35:40 UTC

Permalink

This should be fixed in 8009f7e in girara's develop branch.

Regards

--
Sebastian Ramacher

Abdó Roig-Maranges

2014-05-03 11:05:24 UTC

Permalink

Hi,

Post by Sebastian Ramacher

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
There is a separator that appears in 2 places: around the input buffer in
the statusbar, and between commands and descriptions in the completion menu.
[...]

This should be fixed in 8009f7e in girara's develop branch.

I attach a patch removing the padding for the statusbar, which casued vertical
strips of default-bg color, the same as in the completion menu.

Abd?.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-padding.patch
Type: text/x-diff
Size: 891 bytes
Desc: remove padding on statusbar
URL: <http://lists.pwmt.org/archive/zathura/attachments/20140503/c7c902c3/attachment.patch>

Sebastian Ramacher

2014-05-07 15:09:27 UTC

Permalink

Post by AbdÃ³ Roig-Maranges
Hi,

Post by Sebastian Ramacher

This should be fixed in 8009f7e in girara's develop branch.

I attach a patch removing the padding for the statusbar, which casued vertical
strips of default-bg color, the same as in the completion menu.

Thank you! Applied.

Cheers

--
Sebastian Ramacher

Sebastian Ramacher

2014-04-26 21:34:17 UTC

Permalink

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
In that case, the index colors mode could well be due to an issue with
girara.
Should I file a bug report or is this mail sufficient?

There's now index-{fg,bg} and index-active-{fg,bg} to style the index mode. It
defaults to the same as the completion for now.

Cheers

--
Sebastian Ramacher

Αριστοτέλης Πανάρας

2014-04-27 04:37:28 UTC

Permalink

Thank you. I will check it out after I work out some things out with
jumanji.

Post by Sebastian Ramacher

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
In that case, the index colors mode could well be due to an issue with
girara.
Should I file a bug report or is this mail sufficient?

There's now index-{fg,bg} and index-active-{fg,bg} to style the index mode. It
defaults to the same as the completion for now.
Cheers
--
Sebastian Ramacher
_______________________________________________
zathura mailing list
zathura at lists.pwmt.org
http://lists.pwmt.org/mailman/listinfo/zathura

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pwmt.org/archive/zathura/attachments/20140427/026b5f85/attachment.html>

Sebastian Ramacher

2014-04-23 23:43:36 UTC

Permalink

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï
1. On develop branch, and more specifically commit 3285d61, setting
jumplist-size option in zathurarc seems to generate a critical warning.
set jumplist-size 2000
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/djvu.so
version 0.2.3
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/pdf.so
version 0.2.6
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/ps.so
version 0.2.2
debug: (zathura_plugin_manager_load:195) successfully loaded plugin
/usr/lib/zathura/cb.so
version 0.1.2
** (zathura:12942): CRITICAL **: zathura_jumplist_trim: assertion 'zathura
!= NULL && zathura->jumplist.list != NULL && zathura->jumplist.size != 0'
failed
debug: (zathura_init:202) Using plain database backend.
debug: (bus_acquired:88) Bus acquired at 'org.pwmt.zathura.PID-12942'.
debug: (name_acquired:111) Acquired 'org.pwmt.zathura.PID-12942' on session
bus.
debug: (guess_type_magic:57) magic detected filetype: application/pdf
debug: (zathura_jumplist_load:1364) Loaded the jumplist from the database
debug: (page_cache_is_cached:820) Page 1 is a cache miss
debug: (zathura_renderer_page_cache_add:920) Page 1 is cached at cache
index 0
debug: (render_job:749) Rendering page 1 ...
debug: (emit_completed_signal:505) Emitting signal for page 1

Fixed in develop.

Cheers

--
Sebastian Ramacher

Αριστοτέλης Πανάρας

2014-04-24 05:45:01 UTC

Permalink

I saw the commit. Thank you.
Trying to update, I ran into some trouble with Sphinx. I will create a new
thread about it.

Post by ÎÏÎ¹ÏÏÎ¿ÏÎÎ»Î·Ï Î Î±Î½Î¬ÏÎ±Ï

'zathura

session

Fixed in develop.
Cheers
--
Sebastian Ramacher
_______________________________________________
zathura mailing list
zathura at lists.pwmt.org
http://lists.pwmt.org/mailman/listinfo/zathura

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pwmt.org/archive/zathura/attachments/20140424/dd9a83f7/attachment.html>