Discussion:
[zathura] [Zathura PATCH 2/2] Hide the inputbar and completion menu before saving the adjustments ratios into a new jump structure
Guillaume Duranceau
2013-07-25 12:25:17 UTC
Permalink
Hello Marwan,

This commit (87a7f2310f44184217b8cd1ec0036b0e86f981c5) breaks
incremental search.

When setting incremental search, the input bar is now hidden (by
zathura_jumplist_add, called from sc_search) just after typing the first
character, resulting in a (sort-of) frozen zathura window (commands
cannot be entered anymore).

I checked that commenting the call to zathura_jumplist_hide_inputbar in
zathura_jumplist_add makes incremental search working again indeed, but
I'm not quite sure how to solve this issue properly. Any idea?

Cheers
--
Guillaume
Marwan Tanager
2013-08-15 05:29:02 UTC
Permalink
Hi, Guillaume.
Post by Guillaume Duranceau
Hello Marwan,
This commit (87a7f2310f44184217b8cd1ec0036b0e86f981c5) breaks
incremental search.
When setting incremental search, the input bar is now hidden (by
zathura_jumplist_add, called from sc_search) just after typing the first
character, resulting in a (sort-of) frozen zathura window (commands
cannot be entered anymore).
I checked that commenting the call to zathura_jumplist_hide_inputbar in
zathura_jumplist_add makes incremental search working again indeed, but
I'm not quite sure how to solve this issue properly. Any idea?
Thanks for reporting this.

It should be fixed now with commit c5e593d3c52f9da18cc0643334ea0e1a335237f1


--
Marwan

Loading...